From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B7C3F97EB0 for ; Wed, 6 Mar 2024 15:12:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9982F18D9C for ; Wed, 6 Mar 2024 15:12:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 15:12:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A469948835 for ; Wed, 6 Mar 2024 15:12:06 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 15:11:50 +0100 Message-Id: <20240306141153.419283-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 14:12:07 -0000 Adds a global summary of the transferred chunk size and count, as well as the average transfer rate of a sync job to it's task log. Patch 1/3 introduces a PullStats object, used to return the relevant data from each pull related method call. Patch 2/3 adds the summary log line to the tasklog. Patch 3/3 finally adapts the current log output to use the functionality of `HumanByte` to produce consistent output. Tested by creating a local sync job and syncing a datastore, checking the output in the tasklog. Chunk counts where compared to `find .chunks -type f -print | wc -l`. Bugtracker link: https://bugzilla.proxmox.com/show_bug.cgi?id=5285 Christian Ebner (3): server: sync: return `PullStats` for pull related methods fix #5285: api: sync: add job summary to task log server: sync: use HumanByte for task log output src/api2/pull.rs | 12 ++++- src/server/pull.rs | 130 ++++++++++++++++++++++++++++++--------------- 2 files changed, 99 insertions(+), 43 deletions(-) -- 2.39.2