From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9F15B97C59 for ; Wed, 6 Mar 2024 13:36:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7FE6916F35 for ; Wed, 6 Mar 2024 13:36:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 13:36:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B16348845 for ; Wed, 6 Mar 2024 13:36:15 +0100 (CET) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 13:35:57 +0100 Message-Id: <20240306123609.164021-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox{, -backup} v2 00/12] auth-api clean up and improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 12:36:16 -0000 this series adds some more functionality to `proxmox-auth-api` and tries to clean it up a little. the first commit moves signing into the keyring itself, instead of exposing openssl's `Signer` further. the second commit replaces our old P-256 ec signatures with the Ed25519 scheme which offers similar security but is a bit more modern and tries to avoid common implementation pitfalls. the third commit adds hmac signing to `proxmox-auth-api`'s `Keyring` which is useful for applications where only one daemon is issueing and verifying tickets. hmac uses symmetric keys and is much more efficient than asymetric signature schemes. the downside being that the verifier and the signer need to be the exact same party, as the verification key can also be used to issue new signatures. the fourth commit uses a constant time comparison for our csrf tokens to dimnish the chance of side-channel attack there. the fifth commit uses the hmac functionality to sign csrf tokens. here we previously used a self-rolled potentially insecure method of generating these tokens. hmac avoids common pitfalls here. the commit also provides a fallback to avoid compatability issues. the next two commits move our password hashing scheme to yescrypt and implement a constant time comparison for password hashes. the final commit for `proxmox-auth-api` cleans up some test cases that were failing for the wrong reasons. the four commits on the proxmox backup server side do the following: - use hmac keys when generating new csrf tokens - upgrade password hashes on log in if they are not using the latest password hash function already - use the auth-api's wrapper types to load authkeys - use Ed25519 keys when generating new auth keys the first and the last commit here will require a bump of `proxmox-auth-api`. the second commit also needs a bump to `proxmox-sys`. proxmox: Stefan Sterz (8): auth-api: move signing into the private key auth-api: move to Ed25519 signatures auth-api: add ability to use hmac singing in keyring auth-api: use constant time comparison for csrf tokens auth-api: move to hmac signing for csrf tokens sys: crypt: move to yescrypt for password hashing sys: crypt: use constant time comparison for password verification auth-api: fix types `compilefail` test proxmox-auth-api/src/api/access.rs | 91 ++++++++++--- proxmox-auth-api/src/api/mod.rs | 6 +- proxmox-auth-api/src/auth_key.rs | 211 +++++++++++++++++++++++------ proxmox-auth-api/src/lib.rs | 2 +- proxmox-auth-api/src/ticket.rs | 40 +++--- proxmox-auth-api/src/types.rs | 10 +- proxmox-sys/Cargo.toml | 3 +- proxmox-sys/src/crypt.rs | 140 ++++++++++++++++++- 8 files changed, 414 insertions(+), 89 deletions(-) proxmox-backup: Stefan Sterz (4): auth: move to hmac keys for csrf tokens auth: upgrade hashes on user log in auth: move to auth-api's private and public keys when loading keys auth: use auth-api when generating keys and generate ec keys src/auth.rs | 35 +++++++---- src/auth_helpers.rs | 148 +++++++++++--------------------------------- 2 files changed, 60 insertions(+), 123 deletions(-) Summary over all repositories: 10 files changed, 474 insertions(+), 212 deletions(-) -- Generated by git-murpp 0.5.0