From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC18E97CC1 for ; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91DF515FA5 for ; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5984248842 for ; Wed, 6 Mar 2024 12:21:06 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 12:21:03 +0100 Message-Id: <20240306112104.2486728-7-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240306112104.2486728-1-d.csapak@proxmox.com> References: <20240306112104.2486728-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 5/6] ui: sync job: don't send delete value on creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 11:21:07 -0000 since that's not a valid api parameter there we have to pass the `isCreate` value through to the inputpanel, we even used it there already but it was never set. Signed-off-by: Dominik Csapak --- www/window/SyncJobEdit.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js index c11103eb..e06fdd81 100644 --- a/www/window/SyncJobEdit.js +++ b/www/window/SyncJobEdit.js @@ -80,6 +80,9 @@ Ext.define('PBS.window.SyncJobEdit', { } return values; }, + cbind: { + isCreate: '{isCreate}', // pass it through + }, column1: [ { xtype: 'pmxDisplayEditField', @@ -266,7 +269,9 @@ Ext.define('PBS.window.SyncJobEdit', { xtype: 'pbsNamespaceMaxDepthReduced', name: 'max-depth', fieldLabel: gettext('Max. Depth'), - deleteEmpty: true, + cbind: { + deleteEmpty: '{!isCreate}', + }, }, { fieldLabel: gettext('Remove vanished'), @@ -321,6 +326,7 @@ Ext.define('PBS.window.SyncJobEdit', { { xtype: 'inputpanel', onGetValues: function(values) { + let me = this; PBS.Utils.delete_if_default(values, 'group-filter'); if (Ext.isArray(values['group-filter'])) { if (values['group-filter'].length === 0) { @@ -331,8 +337,14 @@ Ext.define('PBS.window.SyncJobEdit', { values['group-filter'] = [...new Set(values['group-filter'])]; } } + if (me.isCreate) { + delete values.delete; + } return values; }, + cbind: { + isCreate: '{isCreate}', // pass it through + }, title: gettext('Group Filter'), items: [ { -- 2.39.2