From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 00BE597CF5 for ; Wed, 6 Mar 2024 12:21:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7B6815F57 for ; Wed, 6 Mar 2024 12:21:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 12:21:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF7CA48843 for ; Wed, 6 Mar 2024 12:21:05 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 12:21:00 +0100 Message-Id: <20240306112104.2486728-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240306112104.2486728-1-d.csapak@proxmox.com> References: <20240306112104.2486728-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/6] ui: metrics: don't send digest when creating a new influxdbupd host X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 11:21:37 -0000 we accidentally always tried to load an existing config, even when creating a new entry. This returned the list of all configured ones plus the digest (which gets set by the edit window). When the digest is set, the edit window will send it along, but that does not exist for the create api call, so it failed. To fix it, guard the load behind the `serverid` property, which is only set when we edit an existing entry. Signed-off-by: Dominik Csapak --- www/window/InfluxDbEdit.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/www/window/InfluxDbEdit.js b/www/window/InfluxDbEdit.js index e4467737..b1927d6a 100644 --- a/www/window/InfluxDbEdit.js +++ b/www/window/InfluxDbEdit.js @@ -205,14 +205,16 @@ Ext.define('PBS.window.InfluxDbUdpEdit', { let me = this; me.callParent(); - me.load({ - success: function(response, options) { - let values = response.result.data; - let [_match, host, port] = /^(.*):(\d+)$/.exec(values.host) || []; - values.host = host; - values.port = port; - me.setValues(values); - }, - }); + if (me.serverid) { + me.load({ + success: function(response, options) { + let values = response.result.data; + let [_match, host, port] = /^(.*):(\d+)$/.exec(values.host) || []; + values.host = host; + values.port = port; + me.setValues(values); + }, + }); + } }, }); -- 2.39.2