From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2113797C31 for ; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F0BCD15F93 for ; Wed, 6 Mar 2024 12:21:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 12:21:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9D2804883B for ; Wed, 6 Mar 2024 12:21:05 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 12:20:58 +0100 Message-Id: <20240306112104.2486728-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240306112104.2486728-1-d.csapak@proxmox.com> References: <20240306112104.2486728-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH widget-toolkit 1/1] realms: don't send type and delete on creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 11:21:07 -0000 those are not valid properties for pbs, which is currently the only user of these panels/windows. Sending these parameters will result in the api call failing. When we want to reuse these panels for other products, we'll have to make them a bit more flexible/generic anyway. Signed-off-by: Dominik Csapak --- src/window/AuthEditLDAP.js | 8 ++++---- src/window/AuthEditOpenId.js | 10 ---------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js index eb9700a..0494d3f 100644 --- a/src/window/AuthEditLDAP.js +++ b/src/window/AuthEditLDAP.js @@ -32,10 +32,6 @@ Ext.define('Proxmox.panel.LDAPInputPanel', { onlineHelp: 'user-realms-ldap', onGetValues: function(values) { - if (this.isCreate) { - values.type = this.type; - } - if (values.anonymous_search) { if (!values.delete) { values.delete = []; @@ -51,6 +47,10 @@ Ext.define('Proxmox.panel.LDAPInputPanel', { values.delete.push("password"); } + if (this.isCreate) { + delete values.delete; + } + delete values.anonymous_search; return values; diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js index ca84958..b9648f7 100644 --- a/src/window/AuthEditOpenId.js +++ b/src/window/AuthEditOpenId.js @@ -5,16 +5,6 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', { type: 'openid', - onGetValues: function(values) { - let me = this; - - if (me.isCreate) { - values.type = me.type; - } - - return values; - }, - columnT: [ { xtype: 'textfield', -- 2.39.2