From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 28B3E95CA2 for ; Wed, 28 Feb 2024 12:39:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F29E5AA4C for ; Wed, 28 Feb 2024 12:39:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 28 Feb 2024 12:39:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1707447BE9 for ; Wed, 28 Feb 2024 12:39:22 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Wed, 28 Feb 2024 12:39:16 +0100 Message-Id: <20240228113920.302844-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228113920.302844-1-m.sandoval@proxmox.com> References: <20240228113920.302844-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.687 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [util.rs, github.io] Subject: [pbs-devel] [PATCH proxmox 2/6] remove needless_borrow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2024 11:39:54 -0000 Fixes the clippy lint warning: this expression creates a reference which is immediately dereferenced by the compiler --> proxmox-api-macro/src/util.rs:868:25 | 868 | duplicate(&*target, &path); | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default Signed-off-by: Maximiliano Sandoval --- proxmox-api-macro/src/util.rs | 2 +- proxmox-rest-server/src/worker_task.rs | 2 +- proxmox-schema/src/de/no_schema.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-api-macro/src/util.rs b/proxmox-api-macro/src/util.rs index 324c460d..428b1e4d 100644 --- a/proxmox-api-macro/src/util.rs +++ b/proxmox-api-macro/src/util.rs @@ -865,7 +865,7 @@ pub fn parse_str_value_to_option( path: &syn::Path, nv: syn::parse::ParseStream<'_>, ) { - duplicate(&*target, &path); + duplicate(&*target, path); match nv.parse().and_then(|lit| parse_lit_str(&lit)) { Ok(value) => *target = Some(value), Err(err) => crate::add_error(err), diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs index 4cf24cc4..5bab4cdc 100644 --- a/proxmox-rest-server/src/worker_task.rs +++ b/proxmox-rest-server/src/worker_task.rs @@ -850,7 +850,7 @@ impl WorkerTask { file_opts: setup.file_opts.clone(), ..Default::default() }; - let logger = FileLogger::new(&path, logger_options)?; + let logger = FileLogger::new(path, logger_options)?; let worker = Arc::new(Self { setup, diff --git a/proxmox-schema/src/de/no_schema.rs b/proxmox-schema/src/de/no_schema.rs index 546e5001..45fe08cd 100644 --- a/proxmox-schema/src/de/no_schema.rs +++ b/proxmox-schema/src/de/no_schema.rs @@ -303,7 +303,7 @@ impl<'a> Iterator for SplitList<'a> { type Item = &'a str; fn next(&mut self) -> Option<&'a str> { - let range = super::next_str_entry(&self.input, &mut self.at, self.has_null)?; + let range = super::next_str_entry(self.input, &mut self.at, self.has_null)?; Some(&self.input[range]) } } -- 2.39.2