From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AD8C4942B4 for ; Wed, 21 Feb 2024 15:48:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89AEF1A5B1 for ; Wed, 21 Feb 2024 15:48:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Feb 2024 15:48:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E39234448C for ; Wed, 21 Feb 2024 15:48:28 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 21 Feb 2024 15:48:04 +0100 Message-Id: <20240221144804.455959-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240221144804.455959-1-c.ebner@proxmox.com> References: <20240221144804.455959-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/2] client: pxar: early return on exclude pattern match X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2024 14:48:59 -0000 Move the exclude pattern matching further up to avoid unnecessary instantiation of the metadata object, not needed if the entry was matched. No functional change intended. Signed-off-by: Christian Ebner --- pbs-client/src/pxar/create.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs index fa16abfe..60efb0ce 100644 --- a/pbs-client/src/pxar/create.rs +++ b/pbs-client/src/pxar/create.rs @@ -539,15 +539,6 @@ impl Archiver { None => return Ok(()), }; - let metadata = get_metadata( - fd.as_raw_fd(), - stat, - self.flags(), - self.fs_magic, - &mut self.fs_feature_flags, - self.skip_e2big_xattr, - )?; - let match_path = PathBuf::from("/").join(self.path.clone()); if self .patterns @@ -557,6 +548,15 @@ impl Archiver { return Ok(()); } + let metadata = get_metadata( + fd.as_raw_fd(), + stat, + self.flags(), + self.fs_magic, + &mut self.fs_feature_flags, + self.skip_e2big_xattr, + )?; + let file_name: &Path = OsStr::from_bytes(c_file_name.to_bytes()).as_ref(); match metadata.file_type() { mode::IFREG => { -- 2.39.2