From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7835C93742 for ; Tue, 20 Feb 2024 11:29:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6141849E4 for ; Tue, 20 Feb 2024 11:29:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 20 Feb 2024 11:29:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 366ED43EDC for ; Tue, 20 Feb 2024 11:29:03 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Tue, 20 Feb 2024 11:28:49 +0100 Message-ID: <20240220102859.71349-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs, command.rs] Subject: [pbs-devel] [PATCH v2 proxmox{, -backup} 0/4] output full anyhow context in client X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2024 10:29:04 -0000 Instead of using format_err! and format! to create error messages, we want to move to anyhow::Context and add information to already existing anyhow::Error's. Before we start to gradually phase out the format! error calls, we need to print the whole context + error, because the default anyhow::Error Display implementation doesn't print the actual error. This series starts with the proxmox-backup-client and includes a patch from Fabian that introduces pretty-printing of errors (including the context) and some other high-level stuff from me. The scope is not to remove every format call and add a context everywhere, but to enable this change in the future. Changelog v2: - moved explanation to readme.rst file - remove unwrap, use take() in `if let` - cargo fmt proxmox: Fabian Grünbichler (1): CLI: print fatal errors including causes proxmox-router/README.rst | 95 +++++++++++++++++++++++++++++++ proxmox-router/src/cli/command.rs | 4 +- 2 files changed, 97 insertions(+), 2 deletions(-) create mode 100644 proxmox-router/README.rst proxmox-backup: Gabriel Goller (3): pxar: remove ArchiveError pxar: add UniqueContext helper pxar: use anyhow::Error in PxarBackupStream pbs-client/src/pxar/create.rs | 48 +++++++++++++--------------- pbs-client/src/pxar_backup_stream.rs | 18 +++++------ 2 files changed, 32 insertions(+), 34 deletions(-) Summary over all repositories: 4 files changed, 129 insertions(+), 36 deletions(-) -- murpp v0.4.0