From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CBCE5913E5 for ; Wed, 14 Feb 2024 10:52:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC32AEE8 for ; Wed, 14 Feb 2024 10:52:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Feb 2024 10:52:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B3F5A48127 for ; Wed, 14 Feb 2024 10:52:11 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 14 Feb 2024 10:52:02 +0100 Message-ID: <20240214095207.37024-2-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214095207.37024-1-g.goller@proxmox.com> References: <20240214095207.37024-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [api.rs, create.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 2/2] print full anyhow error context X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2024 09:52:42 -0000 When printing an anyhow::Error using the "{}" formatter, only the outer error will be printed. When using "{:#}" (pretty-print), the whole error with all the contexts will be displayed. Signed-off-by: Gabriel Goller --- pbs-client/src/pxar/create.rs | 2 +- pbs-client/src/pxar_backup_stream.rs | 2 +- proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs index 6dac95d9..4cb095cd 100644 --- a/pbs-client/src/pxar/create.rs +++ b/pbs-client/src/pxar/create.rs @@ -105,7 +105,7 @@ impl std::error::Error for ArchiveError {} impl fmt::Display for ArchiveError { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { - write!(f, "error at {:?}: {}", self.path, self.error) + write!(f, "error at {:?}: {:#}", self.path, self.error) } } diff --git a/pbs-client/src/pxar_backup_stream.rs b/pbs-client/src/pxar_backup_stream.rs index 22a6ffdc..61aee7c2 100644 --- a/pbs-client/src/pxar_backup_stream.rs +++ b/pbs-client/src/pxar_backup_stream.rs @@ -68,7 +68,7 @@ impl PxarBackupStream { .await { let mut error = error2.lock().unwrap(); - *error = Some(err.to_string()); + *error = Some(format!("{:#}", err)); } }; diff --git a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs index c2055222..d0e09e15 100644 --- a/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs +++ b/proxmox-restore-daemon/src/proxmox_restore_daemon/api.rs @@ -361,7 +361,7 @@ fn extract( } .await; if let Err(err) = result { - error!("pxar streaming task failed - {}", err); + error!("pxar streaming task failed - {:#}", err); } }); } else if format == "tar" { -- 2.43.0