From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 79CAE91422 for ; Wed, 14 Feb 2024 10:28:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 503D7A0F for ; Wed, 14 Feb 2024 10:27:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Feb 2024 10:27:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 462014811D for ; Wed, 14 Feb 2024 10:27:32 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Wed, 14 Feb 2024 10:27:30 +0100 Message-Id: <20240214092730.168795-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240214092730.168795-1-m.sandoval@proxmox.com> References: <20240214092730.168795-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [github.io, verifier.rs] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.109.153, 185.199.110.153, 185.199.108.153] Subject: [pbs-devel] [PATCH offline-mirror 2/2] verifier: elide explicit lifetime X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2024 09:28:03 -0000 Fixes the clippy lint: ``` warning: the following explicit lifetimes could be elided: 'msg --> src/helpers/verifier.rs:93:32 | 93 | pub(crate) fn verify_signature<'msg>( | ^^^^ 94 | msg: &'msg [u8], | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 93 ~ pub(crate) fn verify_signature( 94 ~ msg: &[u8], | ``` Signed-off-by: Maximiliano Sandoval --- src/helpers/verifier.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/helpers/verifier.rs b/src/helpers/verifier.rs index 17d36eb..ed986af 100644 --- a/src/helpers/verifier.rs +++ b/src/helpers/verifier.rs @@ -90,8 +90,8 @@ impl<'a> VerificationHelper for Helper<'a> { } /// Verifies GPG-signed `msg` was signed by `key`, returning the verified data without signature. -pub(crate) fn verify_signature<'msg>( - msg: &'msg [u8], +pub(crate) fn verify_signature( + msg: &[u8], key: &[u8], detached_sig: Option<&[u8]>, weak_crypto: &WeakCryptoConfig, -- 2.39.2