From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 26CC190E6E for ; Tue, 13 Feb 2024 10:53:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0A31933E0B for ; Tue, 13 Feb 2024 10:53:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Feb 2024 10:53:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1DEDC47C90 for ; Tue, 13 Feb 2024 10:53:22 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Tue, 13 Feb 2024 10:53:19 +0100 Message-Id: <20240213095320.186188-3-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240213095320.186188-1-m.sandoval@proxmox.com> References: <20240213095320.186188-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.111.153, 185.199.109.153, 185.199.108.153] Subject: [pbs-devel] [PATCH backup 3/4] report: inline errors in writeln! X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2024 09:53:24 -0000 Fixes the clippy lint: ``` warning: `to_string` applied to a type that implements `Display` in `writeln!` args --> src/server/report.rs:141:72 | 141 | let _ = writeln!(out, "error during read-dir - {}", err.to_string()); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args ``` Signed-off-by: Maximiliano Sandoval --- src/server/report.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/server/report.rs b/src/server/report.rs index d97efb14..ca5f04fc 100644 --- a/src/server/report.rs +++ b/src/server/report.rs @@ -126,9 +126,8 @@ fn get_directory_content(path: impl AsRef) -> String { Ok(iter) => iter, Err(err) => { return format!( - "`$ cat '{}*'`\n```\n# read dir failed - {}\n```", + "`$ cat '{}*'`\n```\n# read dir failed - {err}\n```", path.as_ref().display(), - err.to_string(), ); } }; @@ -138,7 +137,7 @@ fn get_directory_content(path: impl AsRef) -> String { let entry = match entry { Ok(entry) => entry, Err(err) => { - let _ = writeln!(out, "error during read-dir - {}", err.to_string()); + let _ = writeln!(out, "error during read-dir - {err}"); continue; } }; -- 2.39.2