From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4CCF39099F for ; Mon, 12 Feb 2024 14:17:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C3221924B for ; Mon, 12 Feb 2024 14:17:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Feb 2024 14:17:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CCCFD478ED for ; Mon, 12 Feb 2024 14:17:36 +0100 (CET) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Mon, 12 Feb 2024 14:17:31 +0100 Message-Id: <20240212131734.454966-6-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240212131734.454966-1-m.sandoval@proxmox.com> References: <20240212131734.454966-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.110.153, 185.199.108.153, 185.199.109.153, 185.199.111.153] Subject: [pbs-devel] [PATCH backup 06/13] access first element with first() rather than get(0) X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2024 13:17:38 -0000 Fixes the clippy lint ``` warning: accessing first element with `self.transports.get(0)` --> pbs-tape/src/lib.rs:283:9 | 283 | / self.transports 284 | | .get(0) | |___________________^ help: try: `self.transports.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default ``` Signed-off-by: Maximiliano Sandoval --- pbs-tape/src/lib.rs | 2 +- pbs-tape/src/sg_pt_changer.rs | 2 +- src/server/realm_sync_job.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pbs-tape/src/lib.rs b/pbs-tape/src/lib.rs index 1de2bc54..8d408b70 100644 --- a/pbs-tape/src/lib.rs +++ b/pbs-tape/src/lib.rs @@ -281,7 +281,7 @@ impl MtxStatus { // (are there changers exposing more than one?) // defaults to 0 for changer that do not report transports self.transports - .get(0) + .first() .map(|t| t.element_address) .unwrap_or(0u16) } diff --git a/pbs-tape/src/sg_pt_changer.rs b/pbs-tape/src/sg_pt_changer.rs index 5b8596f0..3945d18f 100644 --- a/pbs-tape/src/sg_pt_changer.rs +++ b/pbs-tape/src/sg_pt_changer.rs @@ -850,7 +850,7 @@ mod test { .map(|desc| build_storage_descriptor(desc, trailing)) .collect(); - let (desc_len, address) = if let Some(el) = descs.get(0) { + let (desc_len, address) = if let Some(el) = descs.first() { (el.len() as u16, descriptors[0].address) } else { (0u16, 0u16) diff --git a/src/server/realm_sync_job.rs b/src/server/realm_sync_job.rs index 9094c2fa..158c2c37 100644 --- a/src/server/realm_sync_job.rs +++ b/src/server/realm_sync_job.rs @@ -170,7 +170,7 @@ impl LdapRealmSyncJob { "userid attribute `{user_id_attribute}` not in LDAP search result" ) })? - .get(0) + .first() .context("userid attribute array is empty")? .clone(); @@ -233,7 +233,7 @@ impl LdapRealmSyncJob { existing_user: Option<&User>, ) -> User { let lookup = |attribute: &str, ldap_attribute: Option<&String>, schema: &'static Schema| { - let value = result.attributes.get(ldap_attribute?)?.get(0)?; + let value = result.attributes.get(ldap_attribute?)?.first()?; let schema = schema.unwrap_string_schema(); if let Err(e) = schema.check_constraints(value) { -- 2.39.2