From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2879490897 for ; Mon, 12 Feb 2024 11:43:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0748716F29 for ; Mon, 12 Feb 2024 11:43:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Feb 2024 11:43:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 398134797E for ; Mon, 12 Feb 2024 11:43:45 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Mon, 12 Feb 2024 11:43:40 +0100 Message-ID: <20240212104342.73779-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.106 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup] client: add "delete-groups" param to delete namespace X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2024 10:43:46 -0000 The api parameter "delete-groups" was missing on the proxmox-backup-client command. This allows the client to remove non-empty namespaces. Signed-off-by: Gabriel Goller --- proxmox-backup-client/src/namespace.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/proxmox-backup-client/src/namespace.rs b/proxmox-backup-client/src/namespace.rs index ce3f113b..abf31ef4 100644 --- a/proxmox-backup-client/src/namespace.rs +++ b/proxmox-backup-client/src/namespace.rs @@ -132,11 +132,15 @@ async fn create_namespace(param: Value) -> Result<(), Error> { type: BackupNamespace, optional: true, }, + "delete-groups": { + description: "Destroys all groups in the hierarchy.", + optional: true, + }, } }, )] /// Delete an existing namespace. -async fn delete_namespace(param: Value) -> Result<(), Error> { +async fn delete_namespace(param: Value, delete_groups: Option) -> Result<(), Error> { let repo = extract_repository_from_value(¶m)?; let backup_ns = optional_ns_param(¶m)?; @@ -145,7 +149,11 @@ async fn delete_namespace(param: Value) -> Result<(), Error> { } let path = format!("api2/json/admin/datastore/{}/namespace", repo.store()); - let param = json!({ "ns": backup_ns }); + let mut param = json!({ "ns": backup_ns }); + + if let Some(dg) = delete_groups { + param["delete-groups"] = serde_json::to_value(dg)?; + } let client = connect(&repo)?; -- 2.43.0