From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C6DC1C0DD1 for ; Fri, 12 Jan 2024 17:16:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91714349CE for ; Fri, 12 Jan 2024 17:16:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Jan 2024 17:16:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 439F049129 for ; Fri, 12 Jan 2024 17:16:53 +0100 (CET) From: Christoph Heiss To: pbs-devel@lists.proxmox.com Date: Fri, 12 Jan 2024 17:15:56 +0100 Message-ID: <20240112161614.1012311-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20240112161614.1012311-1-c.heiss@proxmox.com> References: <20240112161614.1012311-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Subject: [pbs-devel] [PATCH proxmox v3 01/13] ldap: avoid superfluous allocation when calling .search() X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2024 16:16:54 -0000 The `attrs` parameter of `Ldap::search()` is an `impl AsRef<[impl AsRef]>` anyway, so replace `vec![..]` with `&[..]`. Suggested-by: Wolfgang Bumiller Signed-off-by: Christoph Heiss --- proxmox-ldap/src/lib.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/proxmox-ldap/src/lib.rs b/proxmox-ldap/src/lib.rs index b3b5d65..f9862e2 100644 --- a/proxmox-ldap/src/lib.rs +++ b/proxmox-ldap/src/lib.rs @@ -181,12 +181,7 @@ impl Connection { // only search base to make sure the base_dn exists while avoiding most common size limits let (_, _) = ldap - .search( - &self.config.base_dn, - Scope::Base, - "(objectClass=*)", - vec!["*"], - ) + .search(&self.config.base_dn, Scope::Base, "(objectClass=*)", &["*"]) .await? .success() .context("Could not search LDAP realm, base_dn could be incorrect")?; @@ -319,7 +314,7 @@ impl Connection { let query = format!("(&({}={}))", self.config.user_attr, username); let (entries, _res) = ldap - .search(&self.config.base_dn, Scope::Subtree, &query, vec!["dn"]) + .search(&self.config.base_dn, Scope::Subtree, &query, &["dn"]) .await? .success()?; -- 2.42.0