From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 66270C06B2 for ; Thu, 11 Jan 2024 11:41:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F246F64D for ; Thu, 11 Jan 2024 11:40:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Jan 2024 11:40:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3FD1E4538C for ; Thu, 11 Jan 2024 11:40:38 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 11 Jan 2024 11:40:36 +0100 Message-Id: <20240111104036.3341854-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240111104036.3341854-1-d.csapak@proxmox.com> References: <20240111104036.3341854-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 5/5] ui: tape: add remove media button X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2024 10:41:09 -0000 this only removes media from the inventory, it does not touch the data Signed-off-by: Dominik Csapak --- not super sure about the modal dialog, if we should expose 'force' at all, and if we maybe should word it differently and/or add a hint with a deeper explanation... www/Makefile | 1 + www/tape/TapeInventory.js | 27 ++++++++++++ www/tape/window/MediaRemoveWindow.js | 66 ++++++++++++++++++++++++++++ 3 files changed, 94 insertions(+) create mode 100644 www/tape/window/MediaRemoveWindow.js diff --git a/www/Makefile b/www/Makefile index be7e27ab..c2755ac8 100644 --- a/www/Makefile +++ b/www/Makefile @@ -21,6 +21,7 @@ TAPE_UI_FILES= \ tape/window/Erase.js \ tape/window/EncryptionEdit.js \ tape/window/LabelMedia.js \ + tape/window/MediaRemoveWindow.js \ tape/window/PoolEdit.js \ tape/window/TapeBackup.js \ tape/window/TapeBackupJob.js \ diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js index dba36dac..3039a95a 100644 --- a/www/tape/TapeInventory.js +++ b/www/tape/TapeInventory.js @@ -60,6 +60,27 @@ Ext.define('PBS.TapeManagement.TapeInventory', { }).show(); }, + remove: function() { + let me = this; + let view = me.getView(); + let selection = view.getSelection(); + if (!selection || selection.length < 1) { + return; + } + let uuid = selection[0].data.uuid; + let label = selection[0].data['label-text']; + Ext.create('PBS.TapeManagement.MediaRemoveWindow', { + uuid, + label, + autoShow: true, + listeners: { + destroy: function() { + me.reload(); + }, + }, + }); + }, + moveToVault: function() { let me = this; let view = me.getView(); @@ -206,6 +227,12 @@ Ext.define('PBS.TapeManagement.TapeInventory', { disabled: true, handler: 'format', }, + { + xtype: 'proxmoxButton', + text: gettext('Remove'), + disabled: true, + handler: 'remove', + }, ], features: [ diff --git a/www/tape/window/MediaRemoveWindow.js b/www/tape/window/MediaRemoveWindow.js new file mode 100644 index 00000000..0eb3d6be --- /dev/null +++ b/www/tape/window/MediaRemoveWindow.js @@ -0,0 +1,66 @@ +Ext.define('PBS.TapeManagement.MediaRemoveWindow', { + extend: 'Proxmox.window.Edit', + mixins: ['Proxmox.Mixin.CBind'], + + uuid: undefined, + label: undefined, + + cbindData: function(config) { + let me = this; + return { + uuid: me.uuid, + warning: Ext.String.format(gettext("Are you sure you want to remove tape '{0}' ?"), me.label), + }; + }, + + title: gettext('Remove Media'), + url: `/api2/extjs/tape/media/destroy`, + + layout: 'hbox', + width: 400, + method: 'GET', + isCreate: true, + submitText: gettext('Ok'), + items: [ + { + xtype: 'container', + padding: 0, + layout: { + type: 'hbox', + align: 'stretch', + }, + items: [ + { + xtype: 'component', + cls: [Ext.baseCSSPrefix + 'message-box-icon', + Ext.baseCSSPrefix + 'message-box-warning', + Ext.baseCSSPrefix + 'dlg-icon'], + }, + { + xtype: 'container', + flex: 1, + items: [ + { + xtype: 'displayfield', + cbind: { + value: '{warning}', + }, + }, + { + xtype: 'hidden', + name: 'uuid', + cbind: { + value: '{uuid}', + }, + }, + { + xtype: 'proxmoxcheckbox', + fieldLabel: gettext('Force'), + name: 'force', + }, + ], + }, + ], + }, + ], +}); -- 2.30.2