From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D65DAC06A5 for ; Thu, 11 Jan 2024 11:40:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B52FCF5DE for ; Thu, 11 Jan 2024 11:40:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Jan 2024 11:40:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A9FD2490B2 for ; Thu, 11 Jan 2024 11:40:37 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 11 Jan 2024 11:40:31 +0100 Message-Id: <20240111104036.3341854-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.rs, media.rs, inventory.rs] Subject: [pbs-devel] [PATCH proxmox-backup 0/5] improve duplicate label-text handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2024 10:40:38 -0000 while most of the code assumes each label is unique in the inventory, there is actually no safeguard against doing that. this can lead to confusion about which tape is inserted/online/destroyed/vaulted/etc. so this series tries to improve the handling a bit by logging a warning when encountering this, and also preventing new tapes being labeled with an existing label also add the 'destroy' media function to the ui, so that users can get more easily out of this situation Dominik Csapak (5): tape: handle duplicate label-texts in inventory api: tape: optinally accept uuid for destroy/move media api: tape: don't allow duplicate media label-texts ui: tape inventory: use uuid as id ui: tape: add remove media button src/api2/tape/drive.rs | 79 +++++++++++++++++-------- src/api2/tape/media.rs | 84 ++++++++++++++++++++++----- src/tape/changer/online_status_map.rs | 26 +++++---- src/tape/inventory.rs | 26 ++++++--- www/Makefile | 1 + www/tape/TapeInventory.js | 35 ++++++++++- www/tape/window/MediaRemoveWindow.js | 66 +++++++++++++++++++++ 7 files changed, 257 insertions(+), 60 deletions(-) create mode 100644 www/tape/window/MediaRemoveWindow.js -- 2.30.2