From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 675B0BFFA9 for ; Tue, 9 Jan 2024 18:13:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44CC91B775 for ; Tue, 9 Jan 2024 18:13:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Jan 2024 18:13:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89C6249051 for ; Tue, 9 Jan 2024 18:13:17 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 9 Jan 2024 18:13:05 +0100 Message-Id: <20240109171305.426818-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: [pbs-devel] [PATCH proxmox-backup] datastore: add additional context for get_owner parsing error X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2024 17:13:19 -0000 By this it becomes clear that the error stems from a parsing error when getting the backup group owner. See also: https://forum.proxmox.com/threads/139482/ Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 41c9f4f2..a78f44aa 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -602,7 +602,12 @@ impl DataStore { ) -> Result { let full_path = self.owner_path(ns, backup_group); let owner = proxmox_sys::fs::file_read_firstline(full_path)?; - owner.trim_end().parse() // remove trailing newline + owner + .trim_end() // remove trailing newline + .parse() + .map_err(|err| { + format_err!("parsing owner for {backup_group} failed: {err}") + }) } pub fn owns_backup( -- 2.39.2