From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0566BBABE2 for ; Fri, 15 Dec 2023 13:35:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF7D62446 for ; Fri, 15 Dec 2023 13:34:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 15 Dec 2023 13:34:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 39211479E9 for ; Fri, 15 Dec 2023 13:34:48 +0100 (CET) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Fri, 15 Dec 2023 13:34:44 +0100 Message-Id: <20231215123444.100423-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.144 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v2] fix #3921: client: confusing backup reader error X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2023 12:35:20 -0000 When using the catalog shell command, a common error is that user pass "./files.pxar" instead of "files.pxar". This will result in a cryptic error "... value does not match regex pattern ...". Added some context to the error according to suggestions here [1]. [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=3921 Signed-off-by: Gabriel Goller --- Changes since v1: - inlined variables in `format_err!` call pbs-client/src/backup_reader.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pbs-client/src/backup_reader.rs b/pbs-client/src/backup_reader.rs index 36d8ebcf..526b5bc6 100644 --- a/pbs-client/src/backup_reader.rs +++ b/pbs-client/src/backup_reader.rs @@ -98,7 +98,10 @@ impl BackupReader { pub async fn download(&self, file_name: &str, output: W) -> Result<(), Error> { let path = "download"; let param = json!({ "file-name": file_name }); - self.h2.download(path, Some(param), output).await + self.h2 + .download(path, Some(param), output) + .await + .map_err(|err| format_err!("http2 file download '{file_name}' failed: \n{err}")) } /// Execute a special GET request and send output to a writer -- 2.39.2