From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 16C18BA7BA for ; Thu, 14 Dec 2023 15:49:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E500918A38 for ; Thu, 14 Dec 2023 15:48:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Dec 2023 15:48:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F0D0247635 for ; Thu, 14 Dec 2023 15:48:58 +0100 (CET) From: Filip Schauer To: pbs-devel@lists.proxmox.com Date: Thu, 14 Dec 2023 15:48:19 +0100 Message-Id: <20231214144824.100616-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.161 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH v3 many] fix #4995: Include symlinks in zip file restore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 14:49:00 -0000 Include symlinks when restoring files from a backup as a zip file. Resulting ZIP files were successfully tested on Linux with: zipinfo, unzip, unar On Windows the extracted symlinks show up as regular files containing the path to the destination. As far as I am aware Windows Explorer does not support symlinks in ZIP files. Changes since v2: * Add a FileType enum and embed the symlink target into the enum. * Add unit tests for ZipEncoder to the proxmox-compression crate Changes since v1: * Use P instead of &Path * Fix compile error due to misplaced comma * Check content before symlink_target, since regular files are more common than symlinks proxmox: Filip Schauer (3): compression: Add a FileType enum to ZipEntry compression: Add support for symlinks in zip files compression: Add unit tests for the ZipEncoder proxmox-compression/Cargo.toml | 2 +- proxmox-compression/src/zip.rs | 62 ++++++++++---- proxmox-compression/tests/zip.rs | 134 +++++++++++++++++++++++++++++++ 3 files changed, 181 insertions(+), 17 deletions(-) create mode 100644 proxmox-compression/tests/zip.rs proxmox-backup: Filip Schauer (2): pxar: Adopt FileType enum when creating a ZipEntry fix #4995: pxar: Include symlinks in zip file creation pbs-client/src/pxar/extract.rs | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) -- 2.39.2