From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1358BA117 for ; Wed, 13 Dec 2023 16:38:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D37EBC7AB for ; Wed, 13 Dec 2023 16:38:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Dec 2023 16:38:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8D3A4472D6 for ; Wed, 13 Dec 2023 16:38:27 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 13 Dec 2023 16:38:11 +0100 Message-Id: <20231213153819.391392-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-manager.rs, mod.rs, jobs.rs, proxmox-backup-proxy.rs, lib.rs] Subject: [pbs-devel] [RFC proxmox-backup 0/8] implement sanity check jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2023 15:38:29 -0000 This series of patches implements the logic to run regular sanity check job, with the intention to check various states of e.g. datastores, verification states of backups, possibly missing jobs for datastores, uncovered namespace, load metrics exceeding some threshold values, ecc. and allow to send a user notification on success or error state, in an automated fashion. Currently, only a datastore usage check is implemented as prove of concept. The intenition of this patch series is to get some feedback on the implementation approach and find possible shortcommings in design decisions. Christian Ebner (8): api-types: jobs: add sanity checks job types config: implement sanity check job configuration api: config: sanity check jobs api endpoints server: add sanity check job email notifications server: implement sanity check job api: admin: add sanity check job api endpoints manager: add sanity check jobs management cli commands proxy: add sanity check task to scheduler pbs-api-types/src/jobs.rs | 106 +++++++ pbs-config/src/lib.rs | 1 + pbs-config/src/sanity_check.rs | 57 ++++ src/api2/admin/mod.rs | 2 + src/api2/admin/sanity_check.rs | 111 +++++++ src/api2/config/mod.rs | 2 + src/api2/config/sanity_check.rs | 296 ++++++++++++++++++ src/bin/proxmox-backup-manager.rs | 3 +- src/bin/proxmox-backup-proxy.rs | 41 ++- src/bin/proxmox_backup_manager/mod.rs | 2 + .../proxmox_backup_manager/sanity_check.rs | 126 ++++++++ src/server/email_notifications.rs | 78 +++++ src/server/mod.rs | 3 + src/server/sanity_check_job.rs | 131 ++++++++ 14 files changed, 957 insertions(+), 2 deletions(-) create mode 100644 pbs-config/src/sanity_check.rs create mode 100644 src/api2/admin/sanity_check.rs create mode 100644 src/api2/config/sanity_check.rs create mode 100644 src/bin/proxmox_backup_manager/sanity_check.rs create mode 100644 src/server/sanity_check_job.rs -- 2.39.2