From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F3B54B98DE; Mon, 11 Dec 2023 14:29:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA3D517215; Mon, 11 Dec 2023 14:29:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Mon, 11 Dec 2023 14:29:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C8E34535E; Mon, 11 Dec 2023 14:29:15 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Mon, 11 Dec 2023 14:29:08 +0100 Message-Id: <20231211132908.267921-6-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231211132908.267921-1-l.wagner@proxmox.com> References: <20231211132908.267921-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox v2 5/5] sys: email: use `epoch_to_rfc2822` from proxmox_time X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2023 13:29:16 -0000 `strftime`'s formatting is locale-dependent. If the system locale was set to e.g. de_DE.UTF-8, the `Date` header became invalid (e.g Mo instead of Mon for 'Monday'), tripping up some mail clients (e.g. KMail). This commit should fix this by using the new `epoch_to_rfc2822` function from proxmox_time. Under the hood, this function uses `strftime_l` with a fixed locale (C). Signed-off-by: Lukas Wagner --- proxmox-sys/src/email.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs index be92f30..85d171d 100644 --- a/proxmox-sys/src/email.rs +++ b/proxmox-sys/src/email.rs @@ -63,8 +63,7 @@ pub fn sendmail( } let _ = writeln!(body, "From: {} <{}>", author, mailfrom); let _ = writeln!(body, "To: {}", &recipients); - let localtime = proxmox_time::localtime(now)?; - let rfc2822_date = proxmox_time::strftime("%a, %d %b %Y %T %z", &localtime)?; + let rfc2822_date = proxmox_time::epoch_to_rfc2822(now)?; let _ = writeln!(body, "Date: {}", rfc2822_date); body.push_str("Auto-Submitted: auto-generated;\n"); -- 2.39.2