From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E6EAB3D9E for ; Wed, 29 Nov 2023 15:51:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FB659C51 for ; Wed, 29 Nov 2023 15:51:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 15:51:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F2E8B40F54 for ; Wed, 29 Nov 2023 15:51:25 +0100 (CET) From: Stefan Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 29 Nov 2023 15:51:13 +0100 Message-Id: <20231129145116.202049-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-offline-mirror v2 0/3] improve pom multi-key handling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 14:51:57 -0000 this patch series intends to improve the user experience when a user adds multiple keys to one mirror and wants to use one medium to activate multiple products. the first commit removes the `ProductType` trait that has been moved to `proxmox-subscription` from pom. the second commit handles media with muliple keys for muliple products more gracefully in proxmox-offline-mirror-helper. it only tries to activate subscriptions that have a matching server id. the finally commit just adds some rustfmt clean ups. changes since v1 @ (thanks to Fabian Grünbichler): - moved to a hash map based approach when automatically selecting all applicable keys for the current system Stefan Sterz (3): type: move `ProductType` enum to `proxmox-subscription` helper: improve handling of multiple keys when activating them offline mirror binary: rustfmt clean up src/bin/proxmox-offline-mirror-helper.rs | 101 ++++++++++-------- src/bin/proxmox-offline-mirror.rs | 15 ++- src/bin/proxmox_offline_mirror_cmds/medium.rs | 4 +- .../subscription.rs | 4 +- src/config.rs | 4 +- src/subscription.rs | 4 +- src/types.rs | 44 +------- 7 files changed, 75 insertions(+), 101 deletions(-) -- 2.39.2