From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 56A38B396D for ; Wed, 29 Nov 2023 12:37:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30189559F for ; Wed, 29 Nov 2023 12:36:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 12:36:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2D1BC4088E for ; Wed, 29 Nov 2023 12:36:52 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 29 Nov 2023 12:36:37 +0100 Message-Id: <20231129113637.204053-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231129113637.204053-1-c.ebner@proxmox.com> References: <20231129113637.204053-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/2] api: create default garbage collection schedule X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 11:37:26 -0000 Create a default garbage collection schedule when a datastore is created as part of a disk/zpool creation transaction via e.g. `proxmox-backup-manager disk fs create --disk --add-datastore true` Signed-off-by: Christian Ebner --- src/api2/node/disks/directory.rs | 5 +++-- src/api2/node/disks/zfs.rs | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs index 89260b8e..a3e1ba71 100644 --- a/src/api2/node/disks/directory.rs +++ b/src/api2/node/disks/directory.rs @@ -196,8 +196,9 @@ pub fn create_datastore_disk( if add_datastore { let lock = pbs_config::datastore::lock_config()?; - let datastore: DataStoreConfig = - serde_json::from_value(json!({ "name": name, "path": mount_point }))?; + let datastore: DataStoreConfig = serde_json::from_value( + json!({ "name": name, "path": mount_point, "gc-schedule": String::from("daily") }), + )?; let (config, _digest) = pbs_config::datastore::config()?; diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs index 7bc46986..7b8a3891 100644 --- a/src/api2/node/disks/zfs.rs +++ b/src/api2/node/disks/zfs.rs @@ -311,8 +311,9 @@ pub fn create_zpool( if add_datastore { let lock = pbs_config::datastore::lock_config()?; - let datastore: DataStoreConfig = - serde_json::from_value(json!({ "name": name, "path": mount_point }))?; + let datastore: DataStoreConfig = serde_json::from_value( + json!({ "name": name, "path": mount_point, "gc-scheudle": String::from("daily") }), + )?; let (config, _digest) = pbs_config::datastore::config()?; -- 2.39.2