From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5B8CDB36FB for ; Wed, 29 Nov 2023 09:59:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4509224E1 for ; Wed, 29 Nov 2023 09:59:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 09:59:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8703A423F4 for ; Wed, 29 Nov 2023 09:59:41 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 29 Nov 2023 09:59:41 +0100 Message-Id: <20231129085941.1132329-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup] ui: add 'keep configs' checkbox to datastore removal window X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 08:59:42 -0000 From: Hannes Laimer ... since the API already accepts a boolean for that. Signed-off-by: Hannes Laimer [ DC: actually send the option to the api ] Signed-off-by: Dominik Csapak --- resent the old patch from hannes but added code to make it work, hope thats ok @hannes www/datastore/OptionView.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index 448cd4b3..3ef4d3d5 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -34,7 +34,10 @@ Ext.define('PBS.window.SafeDatastoreDestroy', { getParams: function() { let viewModel = this.getViewModel(); - let params = { 'destroy-data': viewModel.get('destroyData') }; + let params = { + 'destroy-data': viewModel.get('destroyData'), + 'keep-job-configs': viewModel.get('keepJobConfigs'), + }; return `?${Ext.Object.toQueryString(params)}`; }, additionalItems: [{ @@ -45,6 +48,14 @@ Ext.define('PBS.window.SafeDatastoreDestroy', { bind: { value: '{destroyData}', }, + }, { + xtype: 'proxmoxcheckbox', + name: 'keep-job-configs', + boxLabel: gettext("Keep configured jobs and permissions"), + defaultValue: false, + bind: { + value: '{keepJobConfigs}', + }, }, { xtype: 'component', reference: 'noteCmp', -- 2.30.2