From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C13539EBD0 for ; Tue, 28 Nov 2023 14:23:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A831E1741A for ; Tue, 28 Nov 2023 14:23:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 14:23:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ACA4040D59 for ; Tue, 28 Nov 2023 14:23:33 +0100 (CET) From: Markus Frank To: pbs-devel@lists.proxmox.com Date: Tue, 28 Nov 2023 14:23:23 +0100 Message-Id: <20231128132323.162721-7-m.frank@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231128132323.162721-1-m.frank@proxmox.com> References: <20231128132323.162721-1-m.frank@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v3 6/6] tools: prohibit disk wipe of EFI partition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 13:23:34 -0000 If the GUID is c12a7328-f81f-11d2-ba4b-00a0c93ec93b the partition is an EFI Partition and should not be wiped. Since this GUID is used multiple times, a constant for the EFI & BIOS GUID is useful. Signed-off-by: Markus Frank --- src/tools/disks/mod.rs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index beb8178b..0fe57d23 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -39,6 +39,9 @@ lazy_static::lazy_static! { regex::Regex::new(r"host[^/]*/session[^/]*").unwrap(); } +const EFI_PARTITION_TYPE: &str = "c12a7328-f81f-11d2-ba4b-00a0c93ec93b"; +const BIOS_PARTITION_TYPE: &str = "21686148-6449-6e6f-744e-656564454649"; + /// Disk management context. /// /// This provides access to disk information with some caching for faster querying of multiple @@ -844,8 +847,8 @@ fn get_partitions_info( if let (Some(devpath), Some(infos)) = (devpath.as_ref(), lsblk_infos.as_ref()) { for info in infos.iter().filter(|i| i.path.eq(devpath)) { used = match info.partition_type.as_deref() { - Some("21686148-6449-6e6f-744e-656564454649") => PartitionUsageType::BIOS, - Some("c12a7328-f81f-11d2-ba4b-00a0c93ec93b") => PartitionUsageType::EFI, + Some(BIOS_PARTITION_TYPE) => PartitionUsageType::BIOS, + Some(EFI_PARTITION_TYPE) => PartitionUsageType::EFI, Some("6a945a3b-1dd2-11b2-99a6-080020736631") => { PartitionUsageType::ZfsReserved } @@ -1080,6 +1083,12 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc) -> Result<(), Error> for disk_info in get_lsblk_info()?.iter() { if disk_info.path == disk_path_str && disk_info.partition_type.is_some() { is_partition = true; + if matches!( + disk_info.partition_type.as_deref(), + Some(EFI_PARTITION_TYPE) + ) { + bail!("You will not be able to boot if you wipe the EFI partition."); + } } } -- 2.39.2