From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 259189EB55 for ; Tue, 28 Nov 2023 14:01:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02FCB17181 for ; Tue, 28 Nov 2023 14:01:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 14:01:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2BB1840F27 for ; Tue, 28 Nov 2023 14:01:33 +0100 (CET) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Date: Tue, 28 Nov 2023 14:01:24 +0100 Message-Id: <20231128130124.258148-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.007 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup] ui: fix local sync job edit X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 13:01:34 -0000 ... since the store field was cleared when the window opened. Reported-by: Lukas Wagner Fixes: 9039d6709e375f37bb8a21680f6fefb18ee87ab3 Signed-off-by: Hannes Laimer --- the fie www/form/RemoteTargetSelector.js | 4 ++-- www/window/SyncJobEdit.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/www/form/RemoteTargetSelector.js b/www/form/RemoteTargetSelector.js index 9ea802d1..3d066f54 100644 --- a/www/form/RemoteTargetSelector.js +++ b/www/form/RemoteTargetSelector.js @@ -33,10 +33,10 @@ Ext.define('PBS.form.RemoteStoreSelector', { // do nothing. }, - setRemote: function(remote) { + setRemote: function(remote, forceReload = false) { let me = this; - if (me.remote === remote) { + if (!forceReload && me.remote === remote) { return; } diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js index dbd53178..d20def74 100644 --- a/www/window/SyncJobEdit.js +++ b/www/window/SyncJobEdit.js @@ -181,15 +181,15 @@ Ext.define('PBS.window.SyncJobEdit', { remoteField.setDisabled(isLocalSync); storeField.setDisabled(!isLocalSync && !remoteField.value); if (isLocalSync === !!remoteField.value) { - storeField.clearValue(); remoteField.clearValue(); } if (isLocalSync) { storeField.setDisabled(false); rateLimitField.setValue(null); - storeField.setRemote(null); + storeField.setRemote(null, true); } else { + storeField.clearValue(); remoteField.validate(); } }, -- 2.39.2