From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 925989E91F for ; Tue, 28 Nov 2023 11:40:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77B8A1505C for ; Tue, 28 Nov 2023 11:40:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 28 Nov 2023 11:40:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1997544D3B for ; Tue, 28 Nov 2023 11:40:08 +0100 (CET) From: Markus Frank To: pbs-devel@lists.proxmox.com Date: Tue, 28 Nov 2023 11:39:59 +0100 Message-Id: <20231128103959.159650-7-m.frank@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231128103959.159650-1-m.frank@proxmox.com> References: <20231128103959.159650-1-m.frank@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup v2 6/6] tools: prohibit disk wipe of EFI partition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2023 10:40:11 -0000 Signed-off-by: Markus Frank --- This patch is based on a suggestion by Dominik. I am not so sure if we should prohibit wiping EFI partitions. Any opinions on this? src/tools/disks/mod.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index 51919f9e..34ace7d6 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -39,6 +39,8 @@ lazy_static::lazy_static! { regex::Regex::new(r"host[^/]*/session[^/]*").unwrap(); } +const EFI_PARTITION_TYPE: &str = "c12a7328-f81f-11d2-ba4b-00a0c93ec93b"; + /// Disk management context. /// /// This provides access to disk information with some caching for faster querying of multiple @@ -1080,6 +1082,12 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc) -> Result<(), Error> for disk_info in get_lsblk_info()?.iter() { if disk_info.path == disk_path_str && disk_info.partition_type.is_some() { is_partition = true; + if matches!( + disk_info.partition_type.as_deref(), + Some(EFI_PARTITION_TYPE) + ) { + bail!("You will not be able to boot if you wipe the EFI partition."); + } } } -- 2.39.2