From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 100229DD9D for ; Sat, 25 Nov 2023 11:14:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8AB818E22 for ; Sat, 25 Nov 2023 11:13:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 25 Nov 2023 11:13:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF29043FA4 for ; Sat, 25 Nov 2023 11:13:52 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Sat, 25 Nov 2023 11:13:32 +0100 Message-Id: <20231125101332.25221-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs, docs.rs, proxmox.com] Subject: [pbs-devel] [PATCH proxmox-backup] client: change anyhow Error display representation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2023 10:14:24 -0000 Improve error message output by showing the full Error context, using the alternate selector '{:#}" [0]. Without this, only the outermost context is displayed, which in case of pxar extraction errors is mostly not enough to find the underlying issue. [0] https://docs.rs/anyhow/1.0.69/anyhow/struct.Error.html#display-representations Signed-off-by: Christian Ebner --- Current error context just gives to little information, as for example see here https://forum.proxmox.com/threads/136341/ proxmox-backup-client/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 1a13291a..9b680f62 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -1453,7 +1453,7 @@ async fn restore( }, options, ) - .map_err(|err| format_err!("error extracting archive - {}", err))?; + .map_err(|err| format_err!("error extracting archive - {:#}", err))?; } else { let mut writer = std::fs::OpenOptions::new() .write(true) -- 2.39.2