From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A50309D722 for ; Fri, 24 Nov 2023 09:28:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 806479F88 for ; Fri, 24 Nov 2023 09:28:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Nov 2023 09:28:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 946A443A84 for ; Fri, 24 Nov 2023 09:28:22 +0100 (CET) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Fri, 24 Nov 2023 09:28:19 +0100 Message-Id: <20231124082819.46802-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [report.rs] Subject: [pbs-devel] [PATCH proxmox-backup] system-report: fix 'unused Result' warning X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2023 08:28:23 -0000 Signed-off-by: Lukas Wagner --- src/server/report.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/server/report.rs b/src/server/report.rs index 703daa71..ea31cbf9 100644 --- a/src/server/report.rs +++ b/src/server/report.rs @@ -162,7 +162,11 @@ fn get_command_output(exe: &str, args: &Vec<&str>) -> String { .trim_end() .to_string(); if !stderr.is_empty() { - writeln!(out, "\n```\nSTDERR:\n```\n{stderr}"); + // Does not really make sense to append any error + // to 'out' - since that write would probably fail + // too... also, AFAICT this should never fail - + // in case of OOM, Rust will simply abort + let _ = writeln!(out, "\n```\nSTDERR:\n```\n{stderr}"); } out } -- 2.39.2