From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 182FB98983 for ; Wed, 15 Nov 2023 16:48:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00EAA954F for ; Wed, 15 Nov 2023 16:48:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 15 Nov 2023 16:48:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 45442432A8 for ; Wed, 15 Nov 2023 16:48:27 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 15 Nov 2023 16:47:46 +0100 Message-Id: <20231115154813.281564-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231115154813.281564-1-c.ebner@proxmox.com> References: <20231115154813.281564-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH v5 pxar 1/28] fix #3174: decoder: factor out skip_bytes from skip_entry X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2023 15:48:28 -0000 Allows to skip bytes independently of the current entries header, as is implemented by skip_entry. Signed-off-by: Christian Ebner --- Changes since v4: - no changes Changes since v3: - no changes Changes since v2: - no changes Changes since v1: - use `u64` instead of `usize` as type for len parameter of `skip_bytes` src/decoder/mod.rs | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/src/decoder/mod.rs b/src/decoder/mod.rs index d1fb911..a094324 100644 --- a/src/decoder/mod.rs +++ b/src/decoder/mod.rs @@ -562,20 +562,25 @@ impl DecoderImpl { // These utilize additional information and hence are not part of the `dyn SeqRead` impl. // - async fn skip_entry(&mut self, offset: u64) -> io::Result<()> { - let mut len = self.current_header.content_size() - offset; + async fn skip_bytes(&mut self, len: u64) -> io::Result<()> { + let mut remaining = len; let scratch = scratch_buffer(); - while len >= (scratch.len() as u64) { + while remaining >= (scratch.len() as u64) { seq_read_exact(&mut self.input, scratch).await?; - len -= scratch.len() as u64; + remaining -= scratch.len() as u64; } - let len = len as usize; - if len > 0 { - seq_read_exact(&mut self.input, &mut scratch[..len]).await?; + let remaining = remaining as usize; + if remaining > 0 { + seq_read_exact(&mut self.input, &mut scratch[..remaining]).await?; } Ok(()) } + async fn skip_entry(&mut self, offset: u64) -> io::Result<()> { + let len = self.current_header.content_size() - offset; + self.skip_bytes(len).await + } + async fn read_entry_as_bytes(&mut self) -> io::Result> { let size = usize::try_from(self.current_header.content_size()).map_err(io_err_other)?; let data = seq_read_exact_data(&mut self.input, size).await?; -- 2.39.2