From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <m.frank@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA91EA1186 for <pbs-devel@lists.proxmox.com>; Fri, 10 Nov 2023 14:51:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9E659177D for <pbs-devel@lists.proxmox.com>; Fri, 10 Nov 2023 14:50:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Fri, 10 Nov 2023 14:50:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E68447B19 for <pbs-devel@lists.proxmox.com>; Fri, 10 Nov 2023 14:50:31 +0100 (CET) From: Markus Frank <m.frank@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Fri, 10 Nov 2023 14:50:10 +0100 Message-Id: <20231110135010.106015-6-m.frank@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231110135010.106015-1-m.frank@proxmox.com> References: <20231110135010.106015-1-m.frank@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 6/6] prohibit disk wipe of EFI partition X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 10 Nov 2023 13:51:02 -0000 Signed-off-by: Markus Frank <m.frank@proxmox.com> --- This patch is based on a suggestion by Dominik. I am not so sure if we should prohibit wiping EFI partitions. Any opinions on this? src/tools/disks/mod.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index 75d84696..8a28159e 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -1071,6 +1071,12 @@ pub fn wipe_blockdev(disk: &Disk) -> Result<(), Error> { for disk_i in get_lsblk_info()?.iter() { if disk_i.path == disk_path.to_str().unwrap() && disk_i.partition_type.is_some() { is_partition = true; + if matches!( + disk_i.partition_type.as_deref(), + Some("c12a7328-f81f-11d2-ba4b-00a0c93ec93b") + ) { + bail!("You will not be able to boot if you wipe the EFI partition."); + } } } -- 2.39.2