From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF91B9ED60 for ; Fri, 3 Nov 2023 14:38:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F3771E1F9 for ; Fri, 3 Nov 2023 14:37:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 3 Nov 2023 14:37:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E4F81442E7 for ; Fri, 3 Nov 2023 14:37:53 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Fri, 3 Nov 2023 14:37:05 +0100 Message-Id: <20231103133729.2252730-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, lib.rs, catalog.rs, aio.rs, catar.rs, tools.rs, sync.rs, api.rs, pxarcmd.rs, mk-format-hashes.rs, create.rs, main.rs, extract.rs] Subject: [pbs-devel] [PATCH-SERIES v3 pxar proxmox-backup proxmox-widget-toolkit 00/24] fix #3174: improve file-level backup X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2023 13:38:01 -0000 Disclaimer: Version 3 of the patch series remains work in progress and is only intended for review/testing purposes. Changes to the patch series since version 2 are based on the feedback obtained via mailing list or other communication channels. Many thanks to Dominik, Wolfgang and Thomas for testing and discussions. This series of patches prototypes a possible approach to improve the pxar file level backup creation speed. The current approach is to skip encoding of regular file payloads, for which metadata (currently ctime and size) did not change as compared to a previous backup run. Instead of re-encoding the files, a reference to a newly introduced appendix section of the pxar archive will be written. The appendix section will be created as concatenation of indexed chunks from the previous backup run, thereby containing the sequential file payload at a calculated offset with respect to the starting point of the appendix section. Metadata comparison and calculation of the chunks to be indexed for the appendix section is performed using the catalog of a previous backup as reference. In order to be able to calculate the offsets, an updated catalog file format version 2 is introduced which extends the previous version by including the file offset with respect to the pxar archive byte stream, as well as the files ctime. This allows to find the required chunks indexes and the start padding within the concatenated chunks. The catalog reader remains backwards compatible to the catalog file format version 1. During encoding, the chunks needed for the appendix section are injected in the backup upload stream after forcing a chunk boundary when regular pxar encoding is finished. Finally, the pxar archive containing an appendix section are marked as such by appending a final pxar goodbye lookup table only containing the offset to the appendix section start and total size of that section, needed for random access as e.g. to mount the archive via the fuse filesystem implementation. The following lists the most notable changes included in this series since the version 2: - avoid reindexing the same chunks multiple times in the appendix section by looking them up in the already present appendix chunks list and calculate the appendix reference offset accordingly. This now requires to sort entries by their appendix start offset for sequential restore. - reduce appendix reference chunk fragmentation by increasing the file size threshold to 1k. - Fix the WebUIs file browser and single file restore, broken in the previous patch series. - fixes previous catalog and/or dynamic index downloads when either the backup group was empty or no archive with the same name present in the backup The following lists the most notable changes included in this series since the version 1: - fixes and refactors the missing chunk issue by modifying the logic to avoid re-appending the same chunks multiple times if referenced by multiple consecutive files. - fixes a performance issue with catalog lookup being the bottleneck for cases with directories with many entries, resulting in the metadata based file change detection performing worse than the regular mode. - fixes the creation of multi archive backups. All of the archives use the same reference catalog. - the catalog file format is pushed to version 2, including the needed archive offsets as well as ctime for file change detection. - the catalog is fully backward compatible to catalog file format version 1, so both can be decoded by the reader. However, the new version of the catalog file format will be used for all new backups - it is now possible to perform multiple consecutive runs of the backup with metadata based file change detection, no more need to perform the regular run previous to the other one. - change from `incremental` flag to enum based `BackupDetectionMode` parameter for command invocations. - includes a new `proxmox-backup-test-suite` binary to create and run benchmarks to compare the performance of the different detection modes. An invocation of a backup run with this patches now is: ```bash proxmox-backup-client backup