From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE8169B91E for ; Thu, 19 Oct 2023 10:58:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9DAEF179CC for ; Thu, 19 Oct 2023 10:57:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 19 Oct 2023 10:57:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F083142EFA; Thu, 19 Oct 2023 10:57:35 +0200 (CEST) From: Max Carrara To: pbs-devel@lists.proxmox.com Cc: McTwist Date: Thu, 19 Oct 2023 10:57:24 +0200 Message-Id: <20231019085724.385356-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] fix #4779: client: add missing "Connection" header for HTTP2 upgrade X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2023 08:58:07 -0000 This commit adds the missing "Connection: upgrade" HTTP header[1] when requesting an upgrade to HTTP 2. [1]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Upgrade Reported-By: McTwist Signed-off-by: Max Carrara --- pbs-client/src/http_client.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pbs-client/src/http_client.rs b/pbs-client/src/http_client.rs index 90d0d04b..b803c19f 100644 --- a/pbs-client/src/http_client.rs +++ b/pbs-client/src/http_client.rs @@ -764,6 +764,8 @@ impl HttpClient { ); } + req.headers_mut() + .insert("Connection", HeaderValue::from_str("upgrade").unwrap()); req.headers_mut() .insert("UPGRADE", HeaderValue::from_str(&protocol_name).unwrap()); -- 2.39.2