From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ACE289B5F9 for ; Wed, 18 Oct 2023 12:09:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EAC4CD68 for ; Wed, 18 Oct 2023 12:09:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Oct 2023 12:09:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9842042A05 for ; Wed, 18 Oct 2023 12:09:02 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 18 Oct 2023 12:08:57 +0200 Message-Id: <20231018100858.56184-2-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231018100858.56184-1-g.goller@proxmox.com> References: <20231018100858.56184-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.323 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [record.data] Subject: [pbs-devel] [PATCH proxmox-backup] ui: align loading spinner to the left, added label X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2023 10:09:34 -0000 Moved the spinner in the Task View (and in other components that show the status) to the left (`text-align: left`) so that the style matches with the 'OK' and 'Error: ...' text shown in that grid-row. Also added a label 'Running' (considers translations). Note: The `x-grid-row-loading` and new `x-grid-row-loading-left` classes have been moved to the `proxmox-widget-toolkit` repo. Signed-off-by: Gabriel Goller --- www/Utils.js | 4 ++-- www/css/ext6-pbs.css | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index 2eca600e..e92af6c6 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -205,8 +205,8 @@ Ext.define('PBS.Utils', { } if (!record.data['last-run-endtime']) { - metadata.tdCls = 'x-grid-row-loading'; - return ''; + metadata.tdCls = 'x-grid-row-loading-left'; + return `${gettext('Running')}`; } let parsed = Proxmox.Utils.parse_task_status(value); diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css index 5fd65d25..a437ffae 100644 --- a/www/css/ext6-pbs.css +++ b/www/css/ext6-pbs.css @@ -79,12 +79,6 @@ color: black; } -/* loading in task list */ -.x-grid-row-loading { - background: no-repeat center center; - background-image:url(../extjs/theme-crisp/resources/images/loadmask/loading.gif); -} - /* displayfield minheight is wrong */ .x-form-display-field-default { min-height: 20px; -- 2.39.2