From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B792791717 for ; Tue, 3 Oct 2023 16:07:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 98B362A0F for ; Tue, 3 Oct 2023 16:07:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 3 Oct 2023 16:07:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 41CD844866 for ; Tue, 3 Oct 2023 16:07:33 +0200 (CEST) From: Philipp Hufnagl To: pbs-devel@lists.proxmox.com Date: Tue, 3 Oct 2023 16:07:20 +0200 Message-Id: <20231003140720.1635670-1-p.hufnagl@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [snapshot.rs] Subject: [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2023 14:07:34 -0000 When a snapshot gets deleted (forgotten), the proxmox backup client currently returns returns "Result: { "data": null }" This feedback may confuse users therefore this patch changes the output to "Successfully deleted snapshot " Signed-off-by: Philipp Hufnagl --- proxmox-backup-client/src/snapshot.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs index 4ca8015f..1d985a2e 100644 --- a/proxmox-backup-client/src/snapshot.rs +++ b/proxmox-backup-client/src/snapshot.rs @@ -188,13 +188,14 @@ async fn forget_snapshots(param: Value) -> Result { let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store()); - let result = client + client .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?)) .await?; record_repository(&repo); - Ok(result) + println!("Successfully deleted snapshot {}", snapshot); + Ok(Value::Null) } #[api( -- 2.39.2