From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A703F7E1 for ; Fri, 29 Sep 2023 15:39:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FA9B258C for ; Fri, 29 Sep 2023 15:39:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 29 Sep 2023 15:39:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A1CA648E61 for ; Fri, 29 Sep 2023 15:39:24 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 29 Sep 2023 15:39:23 +0200 Message-Id: <20230929133924.2731714-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape: restore: improve variable names X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2023 13:39:26 -0000 some of the variable names did not really tell the full story, so extend them a bit. This makes the intention much clearer. Signed-off-by: Dominik Csapak --- www/tape/window/TapeRestore.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js index c1d3493c..3008f359 100644 --- a/www/tape/window/TapeRestore.js +++ b/www/tape/window/TapeRestore.js @@ -721,7 +721,7 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', { let me = this; let snapshots = []; - let storeCounts = {}; + let selectedStoreCounts = {}; me.getSelection().forEach((rec) => { let id = rec.get('id'); @@ -730,10 +730,10 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', { // only add if not filtered if (me.store.findExact('id', id) !== -1) { snapshots.push(`${store}:${snap}`); - if (storeCounts[store] === undefined) { - storeCounts[store] = 0; + if (selectedStoreCounts[store] === undefined) { + selectedStoreCounts[store] = 0; } - storeCounts[store]++; + selectedStoreCounts[store]++; } }); @@ -745,17 +745,17 @@ Ext.define('PBS.TapeManagement.SnapshotGrid', { } let wholeStores = []; - let wholeStoresSelected = true; - for (const [store, count] of Object.entries(storeCounts)) { - if (me.storeCounts[store] === count) { + let onlyWholeStoresSelected = true; + for (const [store, selectedCount] of Object.entries(selectedStoreCounts)) { + if (me.storeCounts[store] === selectedCount) { wholeStores.push(store); } else { - wholeStoresSelected = false; + onlyWholeStoresSelected = false; break; } } - if (wholeStoresSelected) { + if (onlyWholeStoresSelected) { return wholeStores; } -- 2.30.2