From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DDDC4D290 for ; Wed, 20 Sep 2023 16:11:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B651116810 for ; Wed, 20 Sep 2023 16:11:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Sep 2023 16:11:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DEB5F482E3 for ; Wed, 20 Sep 2023 16:11:27 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Wed, 20 Sep 2023 16:11:24 +0200 Message-Id: <20230920141124.231371-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.379 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jobstate.rs] Subject: [pbs-devel] [PATCH proxmox-backup] fix #4895: jobs: ignore task log not found error X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2023 14:11:28 -0000 Use job starttime as endtime when it is stuck in `JobState::Starting` and no task log exists. A user experienced a power loss, which left a gc job in the `Started` state, but the task log did not exist. This breaks the schedule and no following gc runs. Now the error is simply ignored and a new gc job is started on the next occurence. Signed-off-by: Gabriel Goller --- src/server/jobstate.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs index a13d768b..be9dac42 100644 --- a/src/server/jobstate.rs +++ b/src/server/jobstate.rs @@ -198,8 +198,9 @@ impl JobState { .map_err(|err| format_err!("error parsing upid: {err}"))?; if !worker_is_active_local(&parsed) { - let state = upid_read_status(&parsed) - .map_err(|err| format_err!("error reading upid log status: {err}"))?; + let state = upid_read_status(&parsed).unwrap_or(TaskState::Unknown { + endtime: parsed.starttime, + }); Ok(JobState::Finished { upid, -- 2.39.2