From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 44A59AE71 for ; Fri, 8 Sep 2023 14:56:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 267B0121BF for ; Fri, 8 Sep 2023 14:56:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 8 Sep 2023 14:56:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 25E8143276 for ; Fri, 8 Sep 2023 14:56:14 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Fri, 8 Sep 2023 14:56:10 +0200 Message-Id: <20230908125610.226464-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.426 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2] fix #4823: datastore: ignore vanished files when walking directory X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2023 12:56:45 -0000 When walking through a datastore on a GC run, it can happen that the snapshot is deleted, and then walked over. For example: - read dir entry for group - walk entries (snapshots) - snapshot X is removed/pruned - walking reaches snapshot X, but ENOENT Previously we bailed here, now we just ignore it. Backups that are just created (and a atomic rename from tmpdir happens, which might triggers a ENOENT error) are not a problem here, the GC handles them separately. Signed-off-by: Gabriel Goller --- update v2: - rebased, added log message pbs-datastore/src/datastore.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index d0c2b90a..8a417bfa 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -880,6 +880,9 @@ impl DataStore { return Ok(()); } bail!("cannot continue garbage-collection safely, permission denied on: {path:?}"); + } else if inner.kind() == io::ErrorKind::NotFound { + log::info!("ignoring vanished file: {path:?}"); + return Ok(()); } else { bail!("unexpected error on datastore traversal: {inner} - {path:?}"); } -- 2.39.2