From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 78C8ED896 for ; Mon, 21 Aug 2023 13:48:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5457B16A23 for ; Mon, 21 Aug 2023 13:48:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 13:48:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9FB3542D14 for ; Mon, 21 Aug 2023 13:48:20 +0200 (CEST) From: Max Carrara To: pbs-devel@lists.proxmox.com Date: Mon, 21 Aug 2023 13:48:15 +0200 Message-Id: <20230821114815.837613-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox] client/login: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 11:48:52 -0000 Signed-off-by: Max Carrara --- proxmox-client/src/lib.rs | 4 ++-- proxmox-login/src/tfa.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-client/src/lib.rs b/proxmox-client/src/lib.rs index 4da079d..06f57ff 100644 --- a/proxmox-client/src/lib.rs +++ b/proxmox-client/src/lib.rs @@ -85,13 +85,13 @@ impl HttpApiResponse { match self.content_type.as_deref() { Some("application/json") => Ok(()), Some(other) => { - return Err(Error::BadApi( + Err(Error::BadApi( format!("expected json body, got {other}",), None, )) } None => { - return Err(Error::BadApi( + Err(Error::BadApi( "expected json body, but no Content-Type was sent".to_string(), None, )) diff --git a/proxmox-login/src/tfa.rs b/proxmox-login/src/tfa.rs index 9f40589..afe44d1 100644 --- a/proxmox-login/src/tfa.rs +++ b/proxmox-login/src/tfa.rs @@ -71,7 +71,7 @@ mod bytes_as_base64url_nopad { pub fn deserialize<'de, D: Deserializer<'de>>(deserializer: D) -> Result, D::Error> { use serde::de::Error; String::deserialize(deserializer).and_then(|string| { - base64::decode_config(&string, base64::URL_SAFE_NO_PAD) + base64::decode_config(string, base64::URL_SAFE_NO_PAD) .map_err(|err| Error::custom(err.to_string())) }) } -- 2.39.2