From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9A199D70C for ; Mon, 21 Aug 2023 09:40:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 826EB140BB for ; Mon, 21 Aug 2023 09:40:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 09:40:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C0D0842A0D for ; Mon, 21 Aug 2023 09:40:14 +0200 (CEST) From: Gabriel Goller To: pbs-devel@lists.proxmox.com Date: Mon, 21 Aug 2023 09:40:10 +0200 Message-Id: <20230821074010.17442-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.416 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] close #3777: api: Add source information to backup logs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 07:40:16 -0000 This will show the ip-address of the client creating the backup in the logs. For example it will output: "starting new backup on datastore 'test1' from ::ffff:192.168.1.192: "host/test/2023-08-21T07:28:10Z"". Signed-off-by: Gabriel Goller --- src/api2/backup/mod.rs | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/api2/backup/mod.rs b/src/api2/backup/mod.rs index 652d5baa..0c996e62 100644 --- a/src/api2/backup/mod.rs +++ b/src/api2/backup/mod.rs @@ -214,10 +214,21 @@ fn upgrade_to_backup_protocol( env.debug = debug; env.last_backup = last_backup; - env.log(format!( - "starting new {} on datastore '{}': {:?}", - worker_type, store, path - )); + match rpcenv.get_client_ip() { + Some(address) => { + env.log(format!( + "starting new {} on datastore '{}' from {}: {:?}", + worker_type, store, address.ip(), path + )); + }, + None => { + env.log(format!( + "starting new {} on datastore '{}': {:?}", + worker_type, store, path + )); + + } + } let service = H2Service::new(env.clone(), worker.clone(), &BACKUP_API_ROUTER, debug); -- 2.39.2