From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08428AC07 for ; Tue, 8 Aug 2023 10:02:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E6F2F6866 for ; Tue, 8 Aug 2023 10:02:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Aug 2023 10:02:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AF7B8436A9 for ; Tue, 8 Aug 2023 10:02:04 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Tue, 8 Aug 2023 10:01:47 +0200 Message-Id: <20230808080153.79587-9-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230808080153.79587-1-l.wagner@proxmox.com> References: <20230808080153.79587-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -1.449 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FSL_BULK_SIG 0.001 Bulk signature with no Unsubscribe KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RAZOR2_CF_RANGE_51_100 1.886 Razor2 gives confidence level above 50% RAZOR2_CHECK 0.922 Listed in Razor2 (http://razor.sf.net/) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 09/15] clippy fix: unnecessary use of `to_string` X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2023 08:02:09 -0000 See: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned Signed-off-by: Lukas Wagner --- proxmox-openid/src/http_client.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-openid/src/http_client.rs b/proxmox-openid/src/http_client.rs index e391421..1850d64 100644 --- a/proxmox-openid/src/http_client.rs +++ b/proxmox-openid/src/http_client.rs @@ -54,15 +54,15 @@ fn ureq_agent() -> Result { pub fn http_client(request: HttpRequest) -> Result { let agent = ureq_agent()?; let mut req = if let Method::POST = request.method { - agent.post(&request.url.to_string()) + agent.post(request.url.as_ref()) } else { - agent.get(&request.url.to_string()) + agent.get(request.url.as_ref()) }; for (name, value) in request.headers { if let Some(name) = name { req = req.set( - &name.to_string(), + name.as_ref(), value.to_str().map_err(|_| { Error::Other(format!( "invalid {} header value {:?}", -- 2.39.2