From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 84851ED8A for ; Thu, 20 Jul 2023 12:24:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6D94511359 for ; Thu, 20 Jul 2023 12:24:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Jul 2023 12:24:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 321F241D87 for ; Thu, 20 Jul 2023 12:24:07 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Thu, 20 Jul 2023 12:23:56 +0200 Message-Id: <20230720102356.1906013-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230720102356.1906013-1-f.gruenbichler@proxmox.com> References: <20230720102356.1906013-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH proxmox-backup 2/2] blobs: fix outdated comment about file format X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2023 10:24:08 -0000 the wrong info here was rather misleading, especially when encountering errors just talking about "blobs" when the actual problem is with a chunk. chunks did originally have their own magic values, but that got removed in 4ee8f53d07bf0becf19a22cf4f4674558a4d128c "remove DataChunk file format - use DataBlob instead" back in 2019, before the 0.1.1 release(!) Reported-by: Dominik Csapak Signed-off-by: Fabian Grünbichler --- pbs-datastore/src/file_formats.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pbs-datastore/src/file_formats.rs b/pbs-datastore/src/file_formats.rs index 7e08e530..73d67e20 100644 --- a/pbs-datastore/src/file_formats.rs +++ b/pbs-datastore/src/file_formats.rs @@ -35,8 +35,8 @@ pub const DYNAMIC_SIZED_CHUNK_INDEX_1_0: [u8; 8] = [28, 145, 78, 165, 25, 186, 1 /// /// (MAGIC || CRC32 || Data) /// -/// This is basically the same format we use for chunks, but -/// with other magic numbers so that we can distinguish them. +/// This format is used for blobs (stored in a BackupDir and accessed directly) and chunks (stored +/// in a chunk store and accessed via a ChunkReader / index file). #[derive(Endian)] #[repr(C, packed)] pub struct DataBlobHeader { -- 2.39.2