From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA549E424 for ; Tue, 18 Jul 2023 13:57:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C55981A22B for ; Tue, 18 Jul 2023 13:57:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 18 Jul 2023 13:57:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2AC0A430AC for ; Tue, 18 Jul 2023 13:57:10 +0200 (CEST) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Tue, 18 Jul 2023 13:57:07 +0200 Message-Id: <20230718115707.452582-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2023 11:57:41 -0000 The regular `textfield` does not support the `deleteEmpty` setting. Thus, if no comment was entered the configuration would still end up with an empty `comment` key: ldap: foo server .... bind-dn ... comment Fixed by switching over to `proxmoxtextfield`, which properly deletes empty keys. Signed-off-by: Lukas Wagner --- src/window/AuthEditLDAP.js | 2 +- src/window/AuthEditOpenId.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js index 6aafb98..eb9700a 100644 --- a/src/window/AuthEditLDAP.js +++ b/src/window/AuthEditLDAP.js @@ -187,7 +187,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', { columnB: [ { - xtype: 'textfield', + xtype: 'proxmoxtextfield', name: 'comment', fieldLabel: gettext('Comment'), cbind: { diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js index 52a7521..ca84958 100644 --- a/src/window/AuthEditOpenId.js +++ b/src/window/AuthEditOpenId.js @@ -112,7 +112,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', { columnB: [ { - xtype: 'textfield', + xtype: 'proxmoxtextfield', name: 'comment', fieldLabel: gettext('Comment'), cbind: { -- 2.39.2