From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1095AA1BDF for ; Fri, 16 Jun 2023 10:27:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4A7D2FA8B for ; Fri, 16 Jun 2023 10:27:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Jun 2023 10:27:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0168E45B02 for ; Fri, 16 Jun 2023 10:27:32 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Fri, 16 Jun 2023 10:27:30 +0200 Message-Id: <20230616082731.45647-5-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616082731.45647-1-m.sandoval@proxmox.com> References: <20230616082731.45647-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH v2 backup 4/5] clippy fixes: Box::new(_) of default value X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2023 08:27:33 -0000 >From rust-lang: > Why is this bad? > > First, it’s more complex, involving two calls instead of one. Second, > Box::default() can be faster in certain cases. Signed-off-by: Maximiliano Sandoval --- src/acme/plugin.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acme/plugin.rs b/src/acme/plugin.rs index 478d0666..5fe8993d 100644 --- a/src/acme/plugin.rs +++ b/src/acme/plugin.rs @@ -35,7 +35,7 @@ pub(crate) fn get_acme_plugin( } "standalone" => { // this one has no config - Box::new(StandaloneServer::default()) + Box::::default() } other => bail!("missing implementation for plugin type '{}'", other), })) -- 2.39.2