From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D67C6905ED for ; Thu, 30 Mar 2023 13:29:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2D9F1B491 for ; Thu, 30 Mar 2023 13:28:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 30 Mar 2023 13:28:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 56DE741996 for ; Thu, 30 Mar 2023 13:28:46 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 30 Mar 2023 13:28:42 +0200 Message-Id: <20230330112845.2620964-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mam.rs] Subject: [pbs-devel] [PATCH proxmox-backup 1/4] tape: use correct MAM attribute definitions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2023 11:29:17 -0000 080Ch: it's binary not ascii, and the length is not specified (hp says 23-n bytes) 0820h and 0821h are also binary and not ascii Signed-off-by: Dominik Csapak --- pbs-tape/src/sg_tape/mam.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pbs-tape/src/sg_tape/mam.rs b/pbs-tape/src/sg_tape/mam.rs index 634b5a29..b1b4d59a 100644 --- a/pbs-tape/src/sg_tape/mam.rs +++ b/pbs-tape/src/sg_tape/mam.rs @@ -133,20 +133,20 @@ static MAM_ATTRIBUTES: &[(u16, u16, MamFormat, &str)] = &[ (0x08_0B, 16, MamFormat::ASCII, "Application Format Version"), ( 0x08_0C, - 50, - MamFormat::ASCII, + 0, // length is not specified for IBM, and HP says 23-n + MamFormat::BINARY, "Volume Coherency Information", ), ( 0x08_20, 36, - MamFormat::ASCII, + MamFormat::BINARY, "Medium Globally Unique Identifier", ), ( 0x08_21, 36, - MamFormat::ASCII, + MamFormat::BINARY, "Media Pool Globally Unique Identifier", ), ( @@ -238,7 +238,7 @@ fn decode_mam_attributes(data: &[u8]) -> Result, Error> { }; if let Some(info) = MAM_ATTRIBUTE_NAMES.get(&head_id) { - if info.1 == head.len { + if info.1 == 0 || info.1 == head.len { let value = match info.2 { MamFormat::ASCII => String::from_utf8_lossy(&data).to_string(), MamFormat::DEC => { -- 2.30.2