From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA158918B for ; Wed, 8 Mar 2023 11:57:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C72CA1F2AD for ; Wed, 8 Mar 2023 11:57:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Mar 2023 11:57:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4697645F5B for ; Wed, 8 Mar 2023 11:57:53 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Wed, 8 Mar 2023 11:57:47 +0100 Message-Id: <20230308105748.296776-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [create.rs] Subject: [pbs-devel] [PATCH proxmox-backup 1/2] fix #4578: use log crate for pxar create logging X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 10:57:55 -0000 since proxmox-backup-client is used in cron jobs and similar automated fashions, PBS_LOG= should control the output.. Signed-off-by: Fabian Grünbichler --- came up a few times in the forum already, follow up to the switch to log pbs-client/src/pxar/create.rs | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs index 1bce3a41..4bc22bf4 100644 --- a/pbs-client/src/pxar/create.rs +++ b/pbs-client/src/pxar/create.rs @@ -113,20 +113,6 @@ struct HardLinkInfo { st_ino: u64, } -/// TODO: make a builder for the create_archive call for fewer parameters and add a method to add a -/// logger which does not write to stderr. -struct Logger; - -impl std::io::Write for Logger { - fn write(&mut self, data: &[u8]) -> io::Result { - std::io::stderr().write(data) - } - - fn flush(&mut self) -> io::Result<()> { - std::io::stderr().flush() - } -} - /// And the error case. struct ErrorReporter; @@ -155,7 +141,6 @@ struct Archiver { device_set: Option>, hardlinks: HashMap, errors: ErrorReporter, - logger: Logger, file_copy_buffer: Vec, } @@ -221,7 +206,6 @@ where device_set, hardlinks: HashMap::new(), errors: ErrorReporter, - logger: Logger, file_copy_buffer: vec::undefined(4 * 1024 * 1024), }; @@ -706,7 +690,7 @@ impl Archiver { } let result = if skip_contents { - writeln!(self.logger, "skipping mount point: {:?}", self.path)?; + log::info!("skipping mount point: {:?}", self.path); Ok(()) } else { self.archive_dir_contents(&mut encoder, dir, false).await -- 2.30.2