From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E7B8E83D4 for ; Fri, 3 Mar 2023 12:39:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D1C51D8D8 for ; Fri, 3 Mar 2023 12:39:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 3 Mar 2023 12:39:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F03BF41CD4 for ; Fri, 3 Mar 2023 12:39:36 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Fri, 3 Mar 2023 12:39:22 +0100 Message-Id: <20230303113924.389256-3-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230303113924.389256-1-f.gruenbichler@proxmox.com> References: <20230303113924.389256-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 2/4] http: sync: remove redundant calls for setting User-Agent X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2023 11:39:37 -0000 the requests are all created via the agent that already contains the user agent, so this internal helper isn't needed anymore. Signed-off-by: Fabian Grünbichler --- AFAICT at least, there shouldn't be anything relying on the agent being present as manually added header.. proxmox-http/src/client/sync.rs | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/proxmox-http/src/client/sync.rs b/proxmox-http/src/client/sync.rs index 9465d8e..228f839 100644 --- a/proxmox-http/src/client/sync.rs +++ b/proxmox-http/src/client/sync.rs @@ -37,19 +37,7 @@ impl Client { Ok(builder.build()) } - fn add_user_agent(&self, req: ureq::Request) -> ureq::Request { - req.set( - "User-Agent", - self.options - .user_agent - .as_deref() - .unwrap_or(DEFAULT_USER_AGENT_STRING), - ) - } - fn call(&self, req: ureq::Request) -> Result { - let req = self.add_user_agent(req); - req.call().map_err(Into::into) } @@ -57,8 +45,6 @@ impl Client { where R: Read, { - let req = self.add_user_agent(req); - req.send(body).map_err(Into::into) } @@ -147,7 +133,6 @@ impl HttpClient for Client { let mut req = self .agent()? .request(request.method().as_str(), &request.uri().to_string()); - req = self.add_user_agent(req); let orig_headers = request.headers(); @@ -195,7 +180,6 @@ impl HttpClient<&[u8], Vec> for Client { let mut req = self .agent()? .request(request.method().as_str(), &request.uri().to_string()); - req = self.add_user_agent(req); let orig_headers = request.headers(); -- 2.30.2