From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD3E992299 for ; Fri, 10 Feb 2023 13:42:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F3712F3FA for ; Fri, 10 Feb 2023 13:42:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Feb 2023 13:42:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E7421466E6 for ; Fri, 10 Feb 2023 13:42:12 +0100 (CET) Date: Fri, 10 Feb 2023 13:42:12 +0100 From: Wolfgang Bumiller To: Lukas Wagner Cc: Proxmox Backup Server development discussion , Fabian =?utf-8?Q?Gr=C3=BCnbichler?= Message-ID: <20230210124212.jiv6dky22j4qakuc@fwblub> References: <20230209133128.695211-1-l.wagner@proxmox.com> <20230209133128.695211-11-l.wagner@proxmox.com> <1676023936.ktlvuvehan.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.188 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 10/18] manager: add commands for managing LDAP realms X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2023 12:42:13 -0000 On Fri, Feb 10, 2023 at 11:30:48AM +0100, Lukas Wagner wrote: > Thanks for the feedback, Fabian! > > On 2/10/23 11:16, Fabian Grünbichler wrote: > > > + proxmox_rest_server::handle_worker(upid).await?; > > > + } > > > + } > > > > possibly late to the party given that the "handle_worker" move got applied already.. > > > > is there a good reason for introducing this instead of calling the endpoint over > > the API and using the "I just spawned a task and want to poll the output" helper > > (pbs_client::view_task_result), like the rest of proxmox-backup-manager does? > > > > Good point. I missed that the functionality was already present ;). > I used the debug-cli client as guidance, since that was what I was using for early > testing. > > It would probably make sense to change it then? Can be changed as a follow-up. Together with the line-length fixups for the docs part. (The rest-server crate will get some more bumps soon anyway, so I can remove it again if we stop using it.)