From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF179921C5 for ; Fri, 10 Feb 2023 09:44:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 99D992D01E for ; Fri, 10 Feb 2023 09:43:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Feb 2023 09:43:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 330FC4672F for ; Fri, 10 Feb 2023 09:43:32 +0100 (CET) Date: Fri, 10 Feb 2023 09:43:31 +0100 From: Wolfgang Bumiller To: Thomas Lamprecht Cc: Proxmox Backup Server development discussion , Stefan Sterz Message-ID: <20230210084331.nypynwchbg23etsj@fwblub> References: <20230209114139.501580-1-s.sterz@proxmox.com> <20230209141654.5r2dkru47uscqbzr@fwblub> <6632febf-c30a-8796-e941-cd5f2d9e471a@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6632febf-c30a-8796-e941-cd5f2d9e471a@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.189 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4521: api/tasks: replace upid as filename for task log downloads X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Feb 2023 08:44:03 -0000 On Thu, Feb 09, 2023 at 05:59:44PM +0100, Thomas Lamprecht wrote: > On 09/02/2023 15:18, Stefan Sterz wrote: > >> It contains colons which seem to be turned to spaces by my browser. > >> Colons in http headers are a bit weird? > > Colons are fine in HTTP header, they don't add any ambiguity on it's own as header > key's are the part from start of line to the _first_ colon. > The RFCs (7231 or the updated 9110) allow all printable ASCII chars (0x21 to 0x7E). > > In fact, if I use `curl -OJ`, telling it to use the content-disposition header, it > does the right thing and safes the file correctly, preserving colons. > > FWICT it's really just due to Windows limitations w.r.t. file naming that the > browser seemingly spread to all platforms (possibly to avoid that Linux user > passing files to Windows users breaks) - maybe open a bug there? x) So what do browsers do with a C source file named 'con.c'? ;-) (You definitely can't clone a git repo containing such a file on a certain platform... ;-) ) > > >> Maybe we should just strip them out or replace them with underscores or > >> something? > > > underscores sound good to me. > > > meh... if, we'd need to adapt PVE again, there I already applied this. I mean, I just found it weird. We have the 'T' for some reason and then the browser uses spaces for colons, it's ugly. But I also don't really actually care as long as it works... (And to be fair, to me, underscores wouldn't even be a *solution*, but rather a hack because I don't trust browsers...)