From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0D7C691E6D for ; Thu, 9 Feb 2023 14:32:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D45A324952 for ; Thu, 9 Feb 2023 14:31:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Feb 2023 14:31:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9F5C546551 for ; Thu, 9 Feb 2023 14:31:36 +0100 (CET) From: Lukas Wagner To: pbs-devel@lists.proxmox.com Date: Thu, 9 Feb 2023 14:31:23 +0100 Message-Id: <20230209133128.695211-14-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230209133128.695211-1-l.wagner@proxmox.com> References: <20230209133128.695211-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.222 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [auth.rs] Subject: [pbs-devel] [PATCH v3 proxmox-backup 13/18] auth: add dummy OpenIdAuthenticator struct X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2023 13:32:08 -0000 When manually adding a user, `lookup_authenticator` is called to verify whether a realm actually exists. Thus is is necessary to have dummy implementation for the `ProxmoxAuthenticator` trait for OpenID realms. Signed-off-by: Lukas Wagner --- src/auth.rs | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/src/auth.rs b/src/auth.rs index 30feb936..a90123d5 100644 --- a/src/auth.rs +++ b/src/auth.rs @@ -12,7 +12,7 @@ use futures::Future; use proxmox_router::http_bail; use serde_json::json; -use pbs_api_types::{LdapMode, LdapRealmConfig, RealmRef, Userid, UsernameRef}; +use pbs_api_types::{LdapMode, LdapRealmConfig, OpenIdRealmConfig, RealmRef, Userid, UsernameRef}; use pbs_buildcfg::configdir; use crate::auth_helpers; @@ -148,6 +148,39 @@ impl ProxmoxAuthenticator for PBS { } } +struct OpenIdAuthenticator(); +/// When a user is manually added, the lookup_authenticator is called to verify that +/// the realm exists. Thus, it is necessary to have an (empty) implementation for +/// OpendID as well. +impl ProxmoxAuthenticator for OpenIdAuthenticator { + fn authenticate_user<'a>( + &'a self, + _username: &'a UsernameRef, + _password: &'a str, + ) -> Pin> + Send + 'a>> { + Box::pin(async move { + http_bail!( + NOT_IMPLEMENTED, + "password authentication is not implemented for OpenID realms" + ); + }) + } + + fn store_password(&self, _username: &UsernameRef, _password: &str) -> Result<(), Error> { + http_bail!( + NOT_IMPLEMENTED, + "storing passwords is not implemented for OpenID realms" + ); + } + + fn remove_password(&self, _username: &UsernameRef) -> Result<(), Error> { + http_bail!( + NOT_IMPLEMENTED, + "storing passwords is not implemented for OpenID realms" + ); + } +} + #[allow(clippy::upper_case_acronyms)] pub struct LdapAuthenticator { config: LdapRealmConfig, @@ -233,6 +266,8 @@ pub fn lookup_authenticator( let (domains, _digest) = pbs_config::domains::config()?; if let Ok(config) = domains.lookup::("ldap", realm) { Ok(Box::new(LdapAuthenticator { config })) + } else if domains.lookup::("openid", realm).is_ok() { + Ok(Box::new(OpenIdAuthenticator())) } else { bail!("unknown realm '{}'", realm); } -- 2.30.2